Only process properties that have actually changed

master
Sven Slootweg 7 years ago
parent f44f95fbf2
commit e0a8385eb0

@ -36,14 +36,23 @@ module.exports = function createObject(options) {
transformedProperties = properties; transformedProperties = properties;
} }
Object.assign(this, transformedProperties); Object.keys(transformedProperties).forEach((property) => {
/* Don't apply unchanged properties, to prevent unnecessary cache or size busting. */
if (Object.keys(transformedProperties).some(property => this.sizeBustingProperties.includes(property))) { if (this[property] === transformedProperties[property]) {
/* If the size changes, the cache should also be implicitly busted. */ delete transformedProperties[property];
this.bustSize(); }
this.bustCache(); });
} else if (Object.keys(transformedProperties).some(property => this.cacheBustingProperties.includes(property))) {
this.bustCache(); if (Object.keys(transformedProperties).length > 0) {
Object.assign(this, transformedProperties);
if (Object.keys(transformedProperties).some(property => this.sizeBustingProperties.includes(property))) {
/* If the size changes, the cache should also be implicitly busted. */
this.bustSize();
this.bustCache();
} else if (Object.keys(transformedProperties).some(property => this.cacheBustingProperties.includes(property))) {
this.bustCache();
}
} }
}, },
render: function renderObject(context, options = {}) { render: function renderObject(context, options = {}) {

Loading…
Cancel
Save