Labels Milestones

New Issue

Incorrect error-throwing behaviour upon encountering an unknown protocol #1

Open

opened 7 years ago by joepie91 · 0 comments

joepie91 commented 7 years ago

Owner

Testcase:

bhttp.get("data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==")

Origin of bug: https://git.cryto.net/joepie91/node-bhttp/src/master/lib/bhttp.coffee#L175

Issues:

• Promise.reject() foo should be Promise.reject(foo) instead
• References non-existent protocol variable, should be request.protocol

Testcase: ```js bhttp.get("data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==") ``` Origin of bug: https://git.cryto.net/joepie91/node-bhttp/src/master/lib/bhttp.coffee#L175 Issues: - `Promise.reject() foo` should be `Promise.reject(foo)` instead - References non-existent `protocol` variable, should be `request.protocol`

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

Labels

Apply labels

Clear labels

No items

No Label

Milestone

Set milestone

Clear milestone

No items

No Milestone

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: joepie91/node-bhttp#1

Write Preview

Loading…

Cancel

Save

There is no content yet.