Incorrect error-throwing behaviour upon encountering an unknown protocol #1

Open
opened 4 years ago by joepie91 · 0 comments
joepie91 commented 4 years ago
Owner

Testcase:

bhttp.get("data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==")

Origin of bug: https://git.cryto.net/joepie91/node-bhttp/src/master/lib/bhttp.coffee#L175

Issues:

  • Promise.reject() foo should be Promise.reject(foo) instead
  • References non-existent protocol variable, should be request.protocol
Testcase: ```js bhttp.get("data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==") ``` Origin of bug: https://git.cryto.net/joepie91/node-bhttp/src/master/lib/bhttp.coffee#L175 Issues: - `Promise.reject() foo` should be `Promise.reject(foo)` instead - References non-existent `protocol` variable, should be `request.protocol`
Sign in to join this conversation.
No Label
No Milestone
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.