joepie91
/
node-bhttp
1
0
Fork 1
Code Issues 4 Pull Requests Releases Wiki Activity
Labels Milestones

Fix assigning properties to non-writable error object (updated) #5

Merged
joepie91 merged 1 commits from ThePendulum/node-bhttp:readonly-error into master 3 years ago
Conversation 1 Commits 1 Files Changed 3
ThePendulum commented 3 years ago

When certain errors such as a response time-out occur, the addErrorData() function would attempt to assign req/res information to the error, failing to do so because errors from the errors library are read-only.

This change removes addErrorData() in favor of using the library's option-style constructor way of assigning arbitrary properties to an error.

When certain errors such as a response time-out occur, the `addErrorData()` function would attempt to assign req/res information to the error, failing to do so because errors from the `errors` library are read-only. This change removes `addErrorData()` in favor of using the library's [option-style constructor](https://github.com/bodenr/errors#defining-error-messages) way of assigning arbitrary properties to an error.
joepie91 merged commit 5539d06789 into master 3 years ago
joepie91 commented 3 years ago
Owner

Thanks! Published in 1.2.8.

Thanks! Published in `1.2.8`.
The pull request has been merged as 5539d06789.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This pull request currently doesn't have any dependencies.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'ThePendulum/node-bhttp:readonly-error'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes