From 08bbd6d5b60114878e5d160eeda7792ca85a94ed Mon Sep 17 00:00:00 2001 From: Futago-za Ryuu Date: Mon, 2 Oct 2017 06:32:20 +0100 Subject: [PATCH] Moved "eslint-env node" to the root It seem's kind of pointless setting the comment "/* eslint-env node */" at the top of only some JavaScript files when nearly all of them are Node.js releated, so I moved this option to the root level config, only leaving the 'lib' folder as "/* eslint-env commonjs */" --- .eslintrc.json | 5 +++-- bin/.eslintrc.json | 8 -------- gulpfile.js | 2 -- lib/.eslintrc.json | 6 ++++++ test/benchmark/run | 2 -- test/server/run | 2 -- 6 files changed, 9 insertions(+), 16 deletions(-) delete mode 100644 bin/.eslintrc.json create mode 100644 lib/.eslintrc.json diff --git a/.eslintrc.json b/.eslintrc.json index 538b931..daf4ad3 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -1,10 +1,11 @@ { "extends": "dmajda", "env": { - "commonjs": true + "node": true }, "root": true, "rules": { - "linebreak-style": 0 + "linebreak-style": 0, + "no-console": 0 } } diff --git a/bin/.eslintrc.json b/bin/.eslintrc.json deleted file mode 100644 index 3316f47..0000000 --- a/bin/.eslintrc.json +++ /dev/null @@ -1,8 +0,0 @@ -{ - "env": { - "node": true - }, - "rules": { - "no-console": 0 - } -} diff --git a/gulpfile.js b/gulpfile.js index 03c9ee9..31dffd3 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -1,7 +1,5 @@ "use strict"; -/* eslint-env node */ - let babelify = require("babelify"); let browserify = require("browserify"); let buffer = require("vinyl-buffer"); diff --git a/lib/.eslintrc.json b/lib/.eslintrc.json new file mode 100644 index 0000000..02e84ca --- /dev/null +++ b/lib/.eslintrc.json @@ -0,0 +1,6 @@ +{ + "env": { + "node": false, + "commonjs": true + } +} diff --git a/test/benchmark/run b/test/benchmark/run index f04e45d..c4c16a3 100644 --- a/test/benchmark/run +++ b/test/benchmark/run @@ -2,8 +2,6 @@ "use strict"; -/* eslint-env node */ - let Runner = require("./runner.js"); let benchmarks = require("./benchmarks.js"); let fs = require("fs"); diff --git a/test/server/run b/test/server/run index 1843fb1..e2bac59 100644 --- a/test/server/run +++ b/test/server/run @@ -2,8 +2,6 @@ "use strict"; -/* eslint-env node */ - let babelify = require("babelify"); let browserify = require("browserify"); let express = require("express");