reportLeftRecursion: Change handling of the |visitedRules| array
Before this commit, the |reportLeftRecursion| pass was written in functional style, passing the |visitedRules| array around as a parameter and making a new copy each time a rule was visited. This apparently caused performance problems in some deeply recursive grammars. This commit makes it so that there is just one array which is shared across all the visitor functions via a closure and modified as rules are visited. I don't like losing the functional style (it was elegant) but performance is more important. Fixes #203.redux
parent
de1704f007
commit
cdeecf750f
Loading…
Reference in New Issue