joepie91/pegjs
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Make infinite loop and left recursion detectors work with named rules

Browse source 
Add missing |named| case to the visitor in lib/compiler/asts.js, which
makes the infinite loop and left recursion detectors work correctly with
named rules.

The missing case caused |make parser| to fail with:

  140:34: Infinite loop detected.
  make: *** [parser] Error 1
This commit is contained in:
David Majda 2015-08-03 16:56:57 +02:00
parent 130cbcfaa3
commit d7d7e87874
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/compiler/asts.js
View file

@ -23,6 +23,7 @@ var asts = {
var advances = visitor.build({ var advances = visitor.build({
rule: advancesExpression, rule: advancesExpression,
named: advancesExpression,
choice: function(node) { choice: function(node) {
return arrays.every(node.alternatives, advances); return arrays.every(node.alternatives, advances);

9
spec/unit/compiler/passes/report-infinite-loops.spec.js
View file

@ -26,6 +26,15 @@ describe("compiler pass |reportInfiniteLoops|", function() {
}); });
it("computes empty string matching correctly", function() { it("computes empty string matching correctly", function() {
expect(pass).toReportError([
'start = a*',
'a "a" = ""'
].join('\n'));
expect(pass).not.toReportError([
'start = a*',
'a "a" = "a"'
].join('\n'));
expect(pass).toReportError('start = ("" / "a" / "b")*'); expect(pass).toReportError('start = ("" / "a" / "b")*');
expect(pass).toReportError('start = ("a" / "" / "b")*'); expect(pass).toReportError('start = ("a" / "" / "b")*');
expect(pass).toReportError('start = ("a" / "b" / "")*'); expect(pass).toReportError('start = ("a" / "b" / "")*');

9
spec/unit/compiler/passes/report-left-recursion.spec.js
View file

@ -40,6 +40,15 @@ describe("compiler pass |reportLeftRecursion|", function() {
}); });
it("computes empty string matching correctly", function() { it("computes empty string matching correctly", function() {
expect(pass).toReportError([
'start = a start',
'a "a" = ""'
].join('\n'));
expect(pass).not.toReportError([
'start = a start',
'a "a" = "a"'
].join('\n'));
expect(pass).toReportError('start = ("" / "a" / "b") start'); expect(pass).toReportError('start = ("" / "a" / "b") start');
expect(pass).toReportError('start = ("a" / "" / "b") start'); expect(pass).toReportError('start = ("a" / "" / "b") start');
expect(pass).toReportError('start = ("a" / "b" / "") start'); expect(pass).toReportError('start = ("a" / "b" / "") start');