From ea688abd02e0dfee24b9747814d8bbe1383e5bce Mon Sep 17 00:00:00 2001 From: Futago-za Ryuu Date: Thu, 28 Dec 2017 00:01:35 +0000 Subject: [PATCH] Fix shadowing issue on UMD format (#499) --- lib/compiler/passes/generate-js.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/compiler/passes/generate-js.js b/lib/compiler/passes/generate-js.js index 07fc570..04651ba 100644 --- a/lib/compiler/passes/generate-js.js +++ b/lib/compiler/passes/generate-js.js @@ -1539,6 +1539,7 @@ function generateJS( ast, options ) { const requires = dependencyIds .map( id => `require("${ js.stringEscape( id ) }")` ) .join( ", " ); + const args = dependencyVars.map( v => "root." + v ).join( ", " ); const params = dependencyVars.join( ", " ); parts.push( [ @@ -1554,7 +1555,7 @@ function generateJS( ast, options ) { parts.push( [ " } else {", - " root." + options.exportVar + " = factory();" + " root." + options.exportVar + " = factory(" + args + ");" ].join( "\n" ) ); }