Add support for callIfNull

pull/4/head
Sven Slootweg 4 years ago
parent 8ed6ad0abe
commit 50b49dc9a8

@ -17,61 +17,85 @@ module.exports.compose = function composeValidators(validators) {
let isRequired = validators.some((rule) => isRequiredMarker(rule)); let isRequired = validators.some((rule) => isRequiredMarker(rule));
let nonMarkerRules = validators.filter((rule) => !isRequiredMarker(rule)); let nonMarkerRules = validators.filter((rule) => !isRequiredMarker(rule));
function callRule({ rule, value, context }) {
try {
let result = isCombinator(rule)
? rule.callback(value, applyValidators, context)
: rule(value, context);
if (result !== undefined) {
if (isValidationResult(result)) {
if (Array.isArray(result.errors)) {
let nonValidationErrors = result.errors.filter((error) => !matchValidationError(error));
if (nonValidationErrors.length === 0) {
return {
errors: result.errors,
newValue: result.newValue
};
} else {
// We should never reach this point, but it could possibly occur if someone erroneously includes non-ValidationError errors in a validationResult. Note that this is a last-ditch handler, and so we only throw the first non-ValidationError error and let the user sort out the rest, if any.
throw nonValidationErrors[0];
}
} else {
throw new Error(`The 'errors' in a validationResult must be an array`);
}
} else if (result instanceof Error) {
// We could interpret returned Errors as either values or a throw substitute. Let's wait for users to file issues, so that we know what people *actually* need here.
throw new Error(`It is currently not allowed to return an Error object from a validator. If you have a reason to need this, please file a bug!`);
} else {
return {
errors: [],
newValue: result
};
}
} else {
return {
errors: [],
newValue: undefined
};
}
} catch (error) {
if (matchValidationError(error)) {
return {
errors: [ error ],
newValue: undefined
};
} else {
throw error;
}
}
}
return function composedValidator(value, context) { return function composedValidator(value, context) {
if (isRequired && value == null) { if (isRequired && value == null) {
return validationResult({ return validationResult({
errors: [ new ValidationError(`Required value is missing`) ], errors: [ new ValidationError(`Required value is missing`) ],
newValue: value newValue: value
}); });
} else if (value != null) { } else {
let lastValue = value; let lastValue = value;
let errors = []; let errors = [];
for (let rule of nonMarkerRules) { for (let rule of nonMarkerRules) {
try { if (value != null || rule.callIfNull === true) {
let result = isCombinator(rule) let result = callRule({
? rule.callback(lastValue, applyValidators, context) rule: rule,
: rule(lastValue, context); value: lastValue,
context: context
if (result !== undefined) { });
let transformedValue;
if (result.newValue != null) {
if (isValidationResult(result)) { lastValue = result.newValue;
if (Array.isArray(result.errors)) {
let nonValidationErrors = result.errors.filter((error) => !matchValidationError(error));
if (nonValidationErrors.length === 0) {
errors = result.errors;
transformedValue = result.newValue;
} else {
// We should never reach this point, but it could possibly occur if someone erroneously includes non-ValidationError errors in a validationResult. Note that this is a last-ditch handler, and so we only throw the first non-ValidationError error and let the user sort out the rest, if any.
throw result.errors[0];
}
} else {
throw new Error(`The 'errors' in a validationResult must be an array`);
}
} else if (result instanceof Error) {
// We could interpret returned Errors as either values or a throw substitute. Let's wait for users to file issues, so that we know what people *actually* need here.
throw new Error(`It is currently not allowed to return an Error object from a validator. If you have a reason to need this, please file a bug!`);
} else {
transformedValue = result;
}
if (transformedValue != null) {
lastValue = transformedValue;
}
} }
} catch (error) {
if (matchValidationError(error)) { if (result.errors.length > 0) {
errors = [ error ]; errors = result.errors;
} else { break;
throw error;
} }
} } else {
continue;
if (errors.length > 0) {
break;
} }
} }
@ -82,8 +106,6 @@ module.exports.compose = function composeValidators(validators) {
? lastValue ? lastValue
: undefined : undefined
}); });
} else {
return validationResult({ newValue: undefined });
} }
}; };
}; };

Loading…
Cancel
Save