validatem/core
1
0
Fork 1
Code Issues 2 Pull requests Releases Wiki Activity

Only run extractFramesGecko when required #4

Merged
joepie91 merged 1 commit from f0x-validatem/core:parse-stacktrace-fix into master 2022-10-29 14:35:58 +02:00
Conversation 0 Commits 1 Files changed 1 +2 -1
f0x commented 2022-10-18 14:53:31 +02:00
Contributor
Copy link

Fixes #2, previous defaultValue call would always evaluate both stacktrace methods, and extractFramesGecko throws an error on a V8 stacktrace because the parsed first line/character number has a ) on the end, which is not a number.

With this code the V8 result is properly returned if available, before evaluating Gecko

Fixes https://git.cryto.net/validatem/core/issues/2, previous `defaultValue` call would always evaluate both stacktrace methods, and `extractFramesGecko` throws an error on a V8 stacktrace because the parsed first line/character number has a `)` on the end, which is not a number. With this code the V8 result is properly returned if available, before evaluating Gecko
f0x added 1 commit 2022-10-18 14:53:32 +02:00
f0x force-pushed parse-stacktrace-fix from 8e663bcf3a to 950b35d9c3 2022-10-29 02:42:29 +02:00 Compare
joepie91 merged commit ff18ea070f into master 2022-10-29 14:35:58 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: validatem/core#4
No description provided.
Delete branch "f0x-validatem/core:parse-stacktrace-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?