validatem
/
core
1
0
Fork 1
Code Issues 2 Pull Requests Releases Wiki Activity

Labels Milestones

Only run extractFramesGecko when required #4

Merged
joepie91 merged 1 commits from f0x-validatem/core:parse-stacktrace-fix into master 2 years ago
Conversation 0 Commits 1 Files Changed 1
f0x commented 2 years ago

Fixes #2, previous defaultValue call would always evaluate both stacktrace methods, and extractFramesGecko throws an error on a V8 stacktrace because the parsed first line/character number has a ) on the end, which is not a number.

With this code the V8 result is properly returned if available, before evaluating Gecko

Fixes https://git.cryto.net/validatem/core/issues/2, previous `defaultValue` call would always evaluate both stacktrace methods, and `extractFramesGecko` throws an error on a V8 stacktrace because the parsed first line/character number has a `)` on the end, which is not a number. With this code the V8 result is properly returned if available, before evaluating Gecko
f0x added 1 commit 2 years ago
f0x force-pushed parse-stacktrace-fix from 8e663bcf3a to 950b35d9c3 2 years ago
joepie91 merged commit ff18ea070f into master 2 years ago
The pull request has been merged as ff18ea070f.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b f0x-validatem-parse-stacktrace-fix master
git pull parse-stacktrace-fix

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff f0x-validatem-parse-stacktrace-fix
git push origin master
Sign in to join this conversation.
Reviewers
Request review
No reviewers
Labels
Apply labels
Clear labels
No items
No Label
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: validatem/core#4
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'f0x-validatem/core:parse-stacktrace-fix'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes